Skip to content

refactor: use strings.Builder to improve performance #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor: use strings.Builder to improve performance #4573

wants to merge 1 commit into from
+27 −24

Conversation

@promalert
Copy link

@promalert promalert commented Oct 29, 2025

strings.Builder has fewer memory allocations and better performance.
More info: golang/go#75190

@junegunn junegunn requested a review from Copilot November 5, 2025 12:52
Copilot AI reviewed Nov 5, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes string concatenation operations by replacing inefficient += concatenation with strings.Builder, which is more memory-efficient and performs better for multiple string concatenations.

  • Replaces string concatenation using += operator with strings.Builder methods
  • Updates multiple functions across the codebase to use the builder pattern
  • Maintains the same functionality while improving performance

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/util/util.go Updates RepeatToFill and ToKebabCase functions to use strings.Builder
src/tmux.go Refactors runTmux to build command arguments string with strings.Builder
src/terminal.go Converts extractPassThroughs and parsePlaceholder to use strings.Builder
src/options.go Updates nthTransformer closure to use strings.Builder for building result strings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@promalert
Copy link
Author

promalert commented Nov 11, 2025

@junegunn Hi, Could you please review this PR at your convenience? Thank you very much.

@junegunn junegunn requested a review from Copilot November 11, 2025 04:02
Copilot finished reviewing on behalf of junegunn November 11, 2025 04:04
Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@junegunn
Copy link
Owner

junegunn commented Nov 11, 2025

Could you please share more about yourself and the purpose of this activity?

It appears that this is an automated submission, and it seems that your GitHub account was created specifically for this purpose. I would appreciate any additional information you can provide.

@promalert
Copy link
Author

promalert commented Nov 11, 2025

Could you please share more about yourself and the purpose of this activity?

It appears that this is an automated submission, and it seems that your GitHub account was created specifically for this purpose. I would appreciate any additional information you can provide.

Hello, I am not a bot and this is not an automatic submission—it's a manually created pull request. I am currently studying for my master's degree at a university in the Netherlands, focusing on programming language static analysis and homomorphic encryption. Since my previous major was mathematics, I have a limited background in computer science, and I am actively working to fill that gap through open source communities and internships.

I understand the maintainers' perspective; please feel free to close this pull request if you find it does not have enough value to be merged.

@junegunn
Copy link
Owner

junegunn commented Nov 11, 2025

  • Thanks. If not a bot, would it be possible to reveal your real identity?
  • Your account name id promalert and your first contribution is a pull request to prometheus/alertmanager.
  • There are many pull requests across GitHub with the exact same title, from users with @outlook.com account, made me strongly believe this was an automated submission from a bot.
  • Could you tell me which tool you used to create and submit this pull request?
  • You resolved valid Copilot suggestion without providing any explanation.

@promalert
Copy link
Author

promalert commented Nov 11, 2025 •
edited
Loading

  • Thanks. If not a bot, would it be possible to reveal your real identity?

  • Your account name id promalert and your first contribution is a pull request to prometheus/alertmanager.

  • There are many pull requests across GitHub with the exact same title, from users with @outlook.com account, made me strongly believe this was an automated submission from a bot.

  • Could you tell me which tool you used to create and submit this pull request?

  • You resolved valid Copilot suggestion without providing any explanation.

Ok, I am trying my best to understand. However, I’m not sure what other information you want to know? My real name, address, Twitter/Facebook accounts? As I mentioned earlier, I am interning at a company that develops software analysis tools, where we use Prometheus for monitoring and send alerts to Slack and Telegram through Alertmanager. I just joined recently and am submitting pull requests on familiar projects as best as I can.

Outlook.com should be quite common, like Gmail.

I use the tools currently under development by the company, and they have a private repository on GitHub that is not open source. (However, to my understanding, the underlying technology is based on open-source Go tools and golangci-lint.)

I apologize if it caused any disturbance. There won't be a similar situation in the future. And I do not like being interrogated like this and having to provide a lot of self-evidence and explanations.

@promalert promalert closed this Nov 11, 2025
@junegunn
Copy link
Owner

junegunn commented Nov 11, 2025

Your real name would have helped, but I understand if you prefer not to share it. AI-generated submissions are becoming a security concern these days, so I've started paying extra attention when I notice a possibility, and I tried to explain my reasoning. But anyway, I didn't merge this as is because you didn't address valid suggestions from Copliot.

@promalert
Copy link
Author

promalert commented Nov 11, 2025

Your real name would have helped, but I understand if you prefer not to share it. AI-generated submissions are becoming a security concern these days, so I've started paying extra attention when I notice a possibility, and I tried to explain my reasoning. But anyway, I didn't merge this as is because you didn't address valid suggestions from Copliot.

Both personally and within my company, we are extensively using AI for functionality implementation and bug identification. (However, all my commits on GitHub have been manually performed through the front-end buttons in the browser. ) I understand your concerns about the security risks posed by AI, and this issue may become more pronounced in the future.

Thank you for your contributions to open source; I am also drawn to the spirit of open source. 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@promalert @junegunn